[#FLM-26] User notes assigned to movies

Filmaster

User notes assigned to movies

Created: 04/Apr/09 03:00 PM Updated: 25/Sep/11 02:19 PM

Component/s:

Film collections, Movie Database

Affects Version/s:

Some far away version

Fix Version/s:

Some far away version

Time Tracking:

Not Specified

Description

« Hide

Users should be able to write personal notes (not readable by anyone else) and assign them to movies.

Model design:
- simple model: 1 movie - many notes, each note assigned to specific user, max length = 2000(?) chars

GUI:
- ajax implementation: click on some icon visible both on movie page and on collections (including recommendations), a textarea appears where users can write their notes
- change the icon to indicate a note exists for film
- non-ajax: just show the notes next to the movies (form always available)

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Borys Musielak added a comment - 01/Jun/09 02:19 PM

It may be a good idea to extend this new feature and also add the info you're requesting (when watched / worth rewatching).
( proposed by mattmakins: http://filmaster.com/forum/filmaster-forum/new-feature-film-watching-logs/ )

[ Permlink | « Hide ]

Łukasz Mrozek added a comment - 11/Feb/10 06:30 PM

I've done a simple implementation based on the look&feel of short review form.
It's using entity called UserFilmNote which contains the note text (max 2000 characters) and foreign keys to user and film entities.
The note form is shown in "rate film" and "view film" subpages below "short review" form and only if user watching those sites is logged in.

The diff file:
http://www.quickfilepost.com/download.do?get=6eb4ae28d60fd4c30105840e3911ac97

What do you think?

[ Permlink | « Hide ]

Borys Musielak added a comment - 12/Feb/10 03:11 AM

Nice.

One bug:

if (note!='' && short_review.length>2000)

- this should probably not be efering to short_review?

TODOs:

A simple test (yes, we stared to write unit tests eventually) that checks both the regular and ajax version of adding and editing a note

Ideally, a link in collections (wishlist, recommendations) would be nice as well, so that users could see / edit their notes on those pages.
An icon should be displayed there (a different one in case we have a note for the film and when we don't), clicking which would trigger the note form to appear and allow the user to edit the read/note.

I also think this is how it should work on the film / rate films page. A small icon should be displayed where the wishlist / shitlist / collection links are located, allowing the users to add notes, but not taking over the screen with a new form.

---

If you have a bitbucket account, I'll add you to the authorized users so that you can check in your changes into filmaster-test.

[ Permlink | « Hide ]

Łukasz Mrozek added a comment - 13/Feb/10 02:27 PM

Regarding bug: it shouldn't - copy&paste always fails...
I'll try to get this working with your spec in mind and report progress here.
My bitbucket account - morskk.