Issue Details (XML | Word | Printable)

Key: FLM-275
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Adam Zieliński
Reporter: Borys Musielak
Votes: 0
Watchers: 0
Operations

Clone this issue
Create sub-task
If you were logged in you would be able to see more operations.
Filmaster

Fix exception handling in get_recent_comments & get_all_recent_comments

Created: 19/Jan/10 12:17 AM   Updated: 25/Sep/11 02:20 PM
Component/s: Walls and activities
Affects Version/s: 1.0.1
Fix Version/s: 1.0.1

Time Tracking:
Not Specified

Issue Links:
Similar
 


 Description  « Hide
Fix exception handling in get_recent_comments & get_all_recent_comments:
in both methods in core/film_helper.py your catch a gerenal exception in database-related block without rethrowing it.
This may lead to hard to examin ProgrammingError bugs. We need to catch a specific exception or write the code without a try/excerpt block.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Borys Musielak added a comment - 19/Jan/10 12:46 AM
I also removed crap code like this from my files and linked the changes to this task: http://bitbucket.org/filmaster/filmaster-test/changeset/f2673650243d/

Adam Zieliński added a comment - 19/Jan/10 02:39 PM
I've removed general exception from film_helper and also from map_url so the code there is less crappy.